Repository navigation
Conversation
Contributor
|
Hi @clayburn Thanks for jumping in with a PR. The discussion is ongoing at https://lists.apache.org/thread.html/s7r281wf76lcy5808c0oszmcdr1cq867 , the project has not yet taken a decision. We will take action once we reach a conclusion. |
Author
|
Thanks @rombert, all good. If the project declines, feel free to just close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JCR-5266
Publishes Build Scans from Jackrabbit builds to Develocity, the ASF's instance. Read more on Develocity.
.mvn/extensions.xml: Develocity Maven extension 2.6.0 and Common Custom User Data extension 2.4.0.mvn/develocity.xml: serverhttps://develocity.apache.org, project IDjackrabbit. It follows Apache Curator's setup: Build Scans are published only when authenticated, and IP addresses are obfuscatedbuild.yml: the Build step exportsDEVELOCITY_ACCESS_KEYfrom a secretGITHUB_ACTIONS(GitHub Actions).mvn/.develocity/(local Develocity state) is added to.gitignoreand excluded from RATI checked this with
mvn -B -ntp validateon Maven 3.10.0. The build succeeded, the extension loaded, and no scan was published because no key was present.apache-rat:checkreports 0 unapproved files. Builds without a key behave as they do today.Before merging: a PMC member needs to open an INFRA JIRA ticket asking for apache/jackrabbit to be given access to the shared
DEVELOCITY_ACCESS_KEYorganisation secret for develocity.apache.org. Until access is granted, CI builds will not publish Build Scans, and nothing will fail. Once access is granted, the Build Scans will not publish from this fork, only from builds which originate fromapache/jackrabbit.@rombert, following up on our conversation at Community Over Code today. Could you file that INFRA request?