Repository navigation
feat(python): read manifests and manifest lists as pyarrow RecordBatchReaders - #3652
Open
mbutrovich wants to merge 2 commits into
Open
mbutrovich wants to merge 2 commits into
mbutrovich wants to merge 2 commits into
Conversation
mbutrovich
marked this pull request as ready for review
November 6, 2026 21:32
4 of 17 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
read_manifest_entries(feat(arrow): read manifest entries into Arrow with arrow-avro #3388) andread_manifest_list(feat(arrow): read manifest lists into Arrow with arrow-avro #3631) haven't been released, so their signatures change without a deprecation.The batch size is 1024 rows. An entry's size grows with the table's column count through the column stats maps. These are the Arrow sizes of 8 MB manifests written by PyIceberg with stats on every long column. The stats compress well, which fits the most entries in 8 MB.
main)Wider tables have larger entries, so fewer fit in an 8 MB manifest. At 1000 columns, a manifest holds fewer than 1024 entries and reads as one batch at either size.
Are these changes tested?
crates/iceberg/src/arrow/manifest.rs.bindings/python/tests/test_manifest.py, which compare the binding's output with PyIceberg's own readers.AI Disclosure
I wrote this PR with help from Claude but understand and support the core approach, implementation, and test coverage.