Repository navigation
Conversation
sam-1112
marked this pull request as ready for review
November 7, 2026 00:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3611.
What changes are included in this PR?
INT96 timestamp coercion preserves a timezone-less Arrow type even when Iceberg requests timestamptz. Projection compatibility checks then exclude the column, causing multi-column reads to silently return NULL.
Coerce confirmed physical INT96 columns to the precision and timezone required by the Iceberg schema, including timezone-only adjustments for timestamptz_ns. Preserve field metadata and nested structures while leaving non-INT96 timestamp types unchanged.
Are these changes tested?
Regression tests compare complete batches and physical projection masks across projection orders, embedded field IDs, name mapping, and positional fallback. Coverage includes genuine NULLs, missing fields and defaults, mixed timestamp encodings, nested structs/lists/maps, and dates outside the nanosecond range.
Validation passed:
Also validated alongside #3624 at 30b9c20. Its additional Name Mapping parameter required a one-line adjustment to the mask-test helper in the isolated checkout.
AI Disclosure
OpenAI Codex assisted with implementation and tests. Review should focus on the assumption that full Arrow primitive traversal matches physical Parquet column order, and on UTC schema-hint handling for INT96 timestamptz types.