Skip to content

Improved handling of idle sessions by AbstractIOSessionPool / H2ConnPool - #715

Open
ok2c wants to merge 1 commit into
apache:masterfrom
ok2c:io-session-pool-improvements
Open

ok2c wants to merge 1 commit into
apache:masterfrom
ok2c:io-session-pool-improvements

Conversation

@ok2c

@ok2c ok2c commented Sep 30, 2026

Copy link
Copy Markdown
Member

@arturobernalg you have been working a lot with the connection pools. Could you please double-check my changes to make sure we are on the same page as far as idle connection handling is concerned?

@ok2c
ok2c requested a review from arturobernalg September 30, 2026 17:01

@arturobernalg arturobernalg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ok2c IOSession#getLastEventTime() is based on System.nanoTime(), while inactivityDeadline() is based on Clock#millis() converted to nanoseconds. These use different time origins, so I don't think they can be compared directly. Am I missing something?

@ok2c

ok2c commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

@arturobernalg I suspected something was off. I misunderstood how System.nanoTime() worked. Now I think we have a problem. Why did we need to convert the i/o reactor timestamps to using System.nanoTime()? What was the point? I will start a discussion on the dev list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants