Repository navigation
Issue #9124 : Remove the UI test that compares variable icon positions - #9184
Merged
bamaer merged 1 commit intoOct 31, 2026
Merged
Conversation
…sitions theVariableIconsLineUpWithTheProvider compared screen positions of the variable icons, which depend on the GTK theme and fails on some Linux desktops (WSL2 Ubuntu 24.04). It doesn't test functionality, so it goes, with its helper. Generated-by: Claude Opus 5.5
Contributor
|
LGTM. Removes only the theme-dependent position check from #9124; the remaining tests and |
bamaer
approved these changes
Oct 31, 2026
jefersonminatozaki
pushed a commit
to jefersonminatozaki/hop
that referenced
this pull request
Nov 3, 2026
…sitions (apache#9184) theVariableIconsLineUpWithTheProvider compared screen positions of the variable icons, which depend on the GTK theme and fails on some Linux desktops (WSL2 Ubuntu 24.04). It doesn't test functionality, so it goes, with its helper. Generated-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
HopAiConfigOptionPluginUiTest.theVariableIconsLineUpWithTheProviderand itsiconXhelper, as Matt suggested on #9124. The test compared the screen positions of variable icons, which depend on the GTK theme: it fails on WSL2 Ubuntu 24.04 (883 vs 909) and passes under Xvfb in CI. It doesn't test functionality. The alignment code inHopAiConfigOptionPluginis unchanged.Testing: the other 3 tests in the class pass (
mvn -Puitest test -pl plugins/tech/ai -Dtest=HopAiConfigOptionPluginUiTest, macOS, JDK 21). Spotless is clean.I used an AI coding assistant for this change (noted in the commit with
Generated-by); I reviewed and tested it.addresses #9124
🤖 Generated with Claude Code