Repository navigation
Conversation
…ismatch Every scheduled Helix CI run currently fails before tests execute: 1. The root pom declared maven-javadoc-plugin twice in pluginManagement (3.2.0 skip=true left behind when apache#2510 added 3.5.0). Newer Maven on the GitHub runners treats the duplicate as a fatal model error: 'build.pluginManagement.plugins.plugin.(groupId:artifactId)' must be unique. Removed the stale 3.2.0 block. 2. Dependabot bumped jackson-databind to 2.22.x while jackson-annotations (2.18.6) and jackson-core (2.18.11) stayed pinned at 2.18.x. databind 2.22 references annotation classes that do not exist in 2.18, so helix-rest tests crashed at class-load time with NoClassDefFoundError: com/fasterxml/jackson/annotation/JsonSerializeAs (e.g. TestAuthValidator). Aligned all modules on databind/core 2.22.3 and annotations 2.22 (annotations now releases without a patch digit). Verified locally: mvn clean install passes, TestAuthValidator and the ZNRecord/Jackson serializer tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Addresses the root cause behind the recent continuous scheduled CI failures (and the flood of auto-filed [Failed CI Test] issue updates), e.g. #3186, #3180, #3179 were unable to even run because the build fails.
Description
Every scheduled
Helix CIrun on master currently fails before any test executes, for two stacked reasons:1. Duplicate
maven-javadoc-pluginin root pompluginManagementPR #2510 added a 3.5.0 declaration (line ~682) without removing the old 3.2.0
skip=trueblock (line ~616). Older Maven only warned; the newer Maven on GitHub's runners treats it as a fatal model error:Since ~Oct 10 every run dies at POM parsing ("No test failure report found"). Removed the stale 3.2.0 block, keeping the 3.5.0 one that #2510 intentionally added.
2. Jackson version mismatch (runs before Oct 10 that did reach tests)
Dependabot bumped
jackson-databindto 2.22.x per-module whilejackson-annotationsstayed at 2.18.6 (helix-rest) andjackson-coreat 2.18.11 (helix-core, helix-view-aggregator). databind 2.22 references annotation classes that don't exist in 2.18, so helix-rest tests crashed at class-load time:Aligned all modules on jackson-databind/jackson-core 2.22.3 and jackson-annotations 2.22 (jackson-annotations now releases without a patch digit — there is no 2.22.0).
Tests
Verified locally with JDK 11:
mvn clean install -DskipTestspasses (previously failed at POM parse with newer Maven).mvn test -Dtest=TestAuthValidatorin helix-rest: Tests run: 2, Failures: 0, Errors: 0 (previously NoClassDefFoundError at instantiation).mvn test -Dtest=TestZNRecordSerializer,TestZNRecordStreamingSerializer,TestJacksonPayloadSerializer,TestZNRecordin helix-core: Tests run: 18, Failures: 0, Errors: 0.Documentation (Optional)
Commits
Code Quality
🤖 Generated with Claude Code