Repository navigation
Conversation
…y tests Change-Id: I1a580f3d781c80a2b5d75c05f727b3d5901bbc6e
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Log-directory permissions and report vote/detail logic can cause test startup failures or inaccurate summaries.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Adds a Yetus-style Jenkins report for read-replica integration tests, including timing, rerun details, and archived logs.
Changes:
- Replaces pytest-html output with a custom console report.
- Captures per-test Python and HBase logs.
- Tracks build-stage timing and publishes the new report through Jenkins.
| File | Description |
|---|---|
.dockerignore |
Reduces root Docker context. |
dev-support/read-replica/.dockerignore |
Excludes generated test artifacts. |
dev-support/read-replica/.env |
Defines cluster log directories. |
dev-support/read-replica/Jenkinsfile |
Publishes and links the console report. |
dev-support/read-replica/README.md |
Documents new report outputs. |
dev-support/read-replica/docker-compose.yml |
Mounts cluster log directories. |
dev-support/read-replica/hbase_nightly_read_replica_test.sh |
Passes timing and log URLs. |
dev-support/read-replica/requirements.txt |
Removes pytest-html dependencies. |
dev-support/read-replica/run_read_replica_integration_tests.sh |
Generates timing data and the report. |
dev-support/read-replica/python/test/conftest.py |
Captures per-attempt logs. |
dev-support/read-replica/python/scripts/render_console_report.py |
Builds the HTML summary. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
taklwu
requested changes
Oct 7, 2026
taklwu
left a comment
Contributor
There was a problem hiding this comment.
few minor changes required, otherwise looks very good!
| from pathlib import Path | ||
|
|
||
|
|
||
| @dataclass |
Contributor
There was a problem hiding this comment.
nit: the more we wrote here, the junit migration for all tests keep popping up in my mind
Change-Id: Ib677feac4f30cbd4e6056d317cc3611035ab9326
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


https://issues.apache.org/jira/browse/HBASE-30465
Summary
This pull request updated the HTML report for Read-Replica integration tests run with Jenkins. Before, the HTML report was generated directly from pytest. This information was useful, but it did not match the Console reports displayed by other Jenkins runs, such as the HBase Nightly tests.
Additional Details
dev-support/read-replica/python/scripts/render_console_report.pyfor generating a minimal console report that's similar to HBase Nightly's console report. This report include a vote value, run time, comment, and relevant logs (if applicable) for each subsystem that's run.dev-support/read-replica/python/test/conftest.py. This is a special pytest file capable of defining fixtures and hooks picked up by pytest automatically. In this case, the file is used to save unit test and HBase logs after each test is ran or reran.dev-support/docker/Dockerfiledev-support/read-replica/docker-compose.yml