Repository navigation
Conversation
Signed-off-by: liuhy <liuhongyu@apache.org>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Related: #1140
Filling an XLSX template can leave an Excel Table at its original area after its data rows expand. A template table at
A1:C2still reopens with that reference after three list records are filled. POI row shifting can also rewrite structured-reference formulas into fixed A1 ranges, so merely resizing the table does not restore the intended formula behavior.What's changed?
finally, including failure cleanup.The implementation uses the existing POI dependency and existing workbook finalization lifecycle. It adds no public builder option or separate table DSL.
Scope
This implements the RFC's initial row-growth behavior for existing XLSX tables with one header row and at most one totals row. Whole-row insertion affects every table intersected by those rows. Without insertion, growth cannot overwrite totals or another table.
Native calculated-column definitions are preserved for Excel to apply; Fesod does not evaluate formulas or materialize formula caches for every generated row. Empty collections leave tables unchanged. Pristine sheet cloning is verified with
inMemory(true)and POI-created independent table parts/names. Cloning an already-filled sheet, advanced clone formula remapping, creating tables, and adding XLS native-table support remain outside this change.Validation
SUM(Orders[Quantity])+Data!B11, actualSUM(Data!B2:B2)+Data!B11../mvnw -B -pl fesod-common,fesod-shaded,fesod-sheet -Dtest=StructuredTableFillTest,FillDataTest -Dsurefire.failIfNoSpecifiedTests=false packagepassed, 40 tests../mvnw -B -pl fesod-common,fesod-shaded,fesod-sheet -Dtest.excludedGroups=fuzz package spotless:check: passed on JDK 17, 1,904 tests (60 common + 1,844 sheet), zero failures/errors/skips.apache-rat:check(zero unapproved/unknown licenses) and the English/Chinese Markdown lint checks passed.ReadSheetHolder:111andSimpleReadCacheSelector:90. A clean checkout of base8005480areproduces both errors. Generation with-Ddoclint=all,-referencepasses; the default reference-check failure remains explicit.Checklist