Repository navigation
fix: include OW2 attribution in ASM licenses - #1266
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1172
Purpose of the pull request
The merged #1176 added the Spring copyright lines to
META-INF/NOTICE, but the OW2 Consortium copyright line identified in #1172 is still absent from the ASM license included in the shaded JAR and source distribution. Both current copies contain the ASM BSD-3-Clause text and INRIA/France Telecom notice but omit the OW2 notice.What's changed?
Add
Copyright (c) 1999-2009, OW2 Consortium <https://www.ow2.org/>to both:fesod-shaded/src/main/resources/META-INF/LICENSEdist/licenses/LICENSE-asm.txtValidation
git diff --checkpasses; the line is present in both copies.Checklist