Repository navigation
build: drop unused spring-boot dependency management entries - #1262
bengbengbalabalabeng merged 1 commit into
Conversation
Signed-off-by: gongzhongqiang <gongzhongqiang@apache.org>
165612f to
ea776bb
Compare
|
Rebased onto the latest For reviewers, some history on why these entries existed in the first place: they were left over from the $ git show cdf48b71^:fesod-examples/fesod-sheet-examples/pom.xml
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-web</artifactId> <!-- no version -->
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId> <!-- no version -->
</dependency>When the examples module was removed, the management entries were not cleaned up along with it — since then they pin an EOL Spring Boot 2.7.18 that nothing resolves anymore (reactor-wide |
Problem
The root
pom.xmlmanages two Spring Boot artifacts that nothing in the project uses:Verified on
main:git grep spring-boot -- '*.xml'hits only the root POM);org.springframework.boot(thespring.mddocs pages describe downstream Spring integration, not a build dependency);mvn dependency:tree -Dincludes=org.springframework.bootresolves zero artifacts.The pins are also stale by policy: Spring Boot 2.7 is EOL, and history shows the entries are dead weight — dependabot's bump of the managed version (#583) was closed unmerged, and the starter-module proposal (#616) was closed too. Until removed, the 2.7.18 pin keeps showing up in dependency scans of every generated POM.
Change
Delete the
spring-boot-starter-web.versionproperty and the twodependencyManagemententries. 12 lines removed, nothing else touched.spring-corestays — it is a real dependency (shaded infesod-shaded).Notes for reviewers
spring-boot-starter-testwithout a version, relying on this management entry. If that PR moves forward it should pin its own version (or propose a fresh, current management entry) rather than depend on an EOL 2.7.18 pin — happy to help rebase it if that lands first.Verification
Full reactor builds green with the entries removed.