Repository navigation
Run the combined service test of ServiceRegistryTest - #578
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
testRegisterCombinedService() had no @test annotation, so JUnit 5 never ran it. Annotate it and name it like the other tests of the class. It passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceRegistryTest.testRegisterCombinedService()is the only test method of the class without@Test. Under JUnit 3 it ran because its name starts withtest, but JUnit 5 never runs it. It checks that a service that implementsListenerHook,FindHookandEventHookis registered as each of the three hooks and removed from all of them on unregistration.This PR adds
@Testand names the methodregisterCombinedService(), like the other tests of the class. The test passes:ServiceRegistryTestnow runs 38 tests instead of 37.