You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[GH-1289] Skip child lookups for empty nodes - #1313
When rebuilding CuratorCache, avoid issuing getChildren for a node whose Stat reports zero children. The recursive persistent watcher is registered before rebuilding, so children created after this check are still delivered as watcher events.
Adds a regression test that initializes the cache with empty nodes and verifies that a child created afterward is observed.
Thanks for the CI signal. I checked run #39507194896: Unit tests (17) failed before Maven started, at ./mvnw clean install -DskipTests, with Could not find or load main class org.apache.maven.wrapper.MavenWrapperMain. The wrapper JAR is intentionally ignored and absent from a clean checkout; this job's wrapper bootstrap did not leave a usable JAR. The other Java/ZooKeeper jobs and the style check passed. The Maven Central wrapper JAR URL currently returns HTTP 200, which suggests a transient bootstrap/download failure, though the quiet wrapper log does not expose its exact cause. I tried rerunning failed jobs, but GitHub requires repository admin rights. Could a maintainer rerun the Java 17 job? The failure happened before compilation, so I have no source change to push for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1289.
When rebuilding CuratorCache, avoid issuing getChildren for a node whose Stat reports zero children. The recursive persistent watcher is registered before rebuilding, so children created after this check are still delivered as watcher events.
Adds a regression test that initializes the cache with empty nodes and verifies that a child created afterward is observed.
Validation:
./mvnw -pl curator-recipes -am -Dtest=TestCuratorCache -Dsurefire.failIfNoSpecifiedTests=false test— passed (6 tests)../mvnw -pl curator-recipes spotless:check— passed.git diff --check— passed.The full reactor and a large-tree performance benchmark were not run; no quantified performance improvement is claimed.