Skip to content

restrict ISBN group separators to a dash or space #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sahvx655-wq wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

restrict ISBN group separators to a dash or space #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/commons/validator/routines/ISBNValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public class ISBNValidator implements Serializable {

private static final long serialVersionUID = 4319515687976420405L;

private static final String SEP = "(?:\\-|\\s)";
private static final String SEP = "[- ]";
private static final String GROUP = "(\\d{1,5})";
private static final String PUBLISHER = "(\\d{1,7})";
private static final String TITLE = "(\\d{1,6})";
Expand Down
10 changes: 10 additions & 0 deletions src/test/java/org/apache/commons/validator/routines/ISBNValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ class ISBNValidatorTest {
"1.2.3.4", // Invalid Separator
"1=2=3=4", // Invalid Separator
"1_2_3_4", // Invalid Separator
"1\t930110\t99\t5", // Invalid Separator: tab
"1\n930110\n99\n5", // Invalid Separator: line feed
"1\r930110\r99\r5", // Invalid Separator: carriage return
"1\u000B930110\u000B99\u000B5", // Invalid Separator: vertical tab
"1\f930110\f99\f5", // Invalid Separator: form feed
"123456789Y", // Other character at the end
"dsasdsadsa", // invalid characters
"I love sparrows!", // invalid characters
Expand All @@ -73,6 +78,11 @@ class ISBNValidatorTest {
"123-4-567890-12-8", // format
"978.1.2.3.4", // Invalid Separator
"978=1=2=3=4", // Invalid Separator
"978\t1\t930110\t99\t1", // Invalid Separator: tab
"978\n1\n930110\n99\n1", // Invalid Separator: line feed
"978\r1\r930110\r99\r1", // Invalid Separator: carriage return
"978\u000B1\u000B930110\u000B99\u000B1", // Invalid Separator: vertical tab
"978\f1\f930110\f99\f1", // Invalid Separator: form feed
"978_1_2_3_4", // Invalid Separator
"978123456789X", // invalid character
"978-0-201-63385-X", // invalid character
Expand Down