Repository navigation
Conversation
The same five String.getBytes(UTF_8) changes are covered by apache#3929. Keeping them here creates duplicate hunks and a merge conflict; remove them so this PR only pins the OpenAPI plugin and removes the unused test helper.
The failed Spark 3.3 job could not resolve fish.payara.maven.extensions:regex-profile-activator:0.5, an infrastructure error unrelated to this diff. Trigger a fresh matrix run.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Clean up two Maven and compiler warnings:
build-helper-maven-pluginto 3.6.0 in the OpenAPI client.genPartitionLocationshelper fromCelebornPartitionUtilSuiteJ.Why are the changes needed?
They remove a missing Maven plugin version warning and an Error Prone
UnusedMethoddiagnostic, with no production behavior change. Other warnings, such as the dynamic POM coordinates and the Shade metadata, are outside the scope of this cleanup.Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
./build/mvn -Pspark-3.5 -pl client-spark/spark-3 -am -Dtest=CelebornPartitionUtilSuiteJ -Dsurefire.failIfNoSpecifiedTests=false test./build/mvn -pl openapi/openapi-client -am -DskipTests package, which confirmsbuild-helper:3.6.0executes without the missing-version warning./build/mvn -Pspark-3.5 -pl openapi/openapi-client,client-spark/spark-3 -am spotless:checkgit diff --check