Repository navigation
[CALCITE-7899] SubQueryRemoveRule binds an outer query's correlation variable to the wrong input when a Project has several sub-queries - #5366
Merged
Conversation
…variable to the wrong input when a Project has several sub-queries
mihaibudiu
reviewed
Oct 28, 2026
| int count = 0; | ||
| List<RexNode> projects = project.getProjects(); | ||
| while (true) { | ||
| final RexSubQuery e = RexUtil.SubQueryFinder.find(projects); |
Contributor
There was a problem hiding this comment.
the other PR attacking a similar problem #5356 uses a new visitor which finds the innermost subquery first.
Contributor
Author
There was a problem hiding this comment.
The earlier PR #5356 bundled fixes for several issues together — I was essentially experimenting with a few possible fix approaches at the time. I have now cleaned that PR up.
|
mihaibudiu
approved these changes
Oct 28, 2026
iwanttobepowerful
added
the
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CALCITE-7899