Repository navigation
Fix compactor thread and metrics leak in RocksDBKVSpace - #320
Open
pallavithegod wants to merge 1 commit into
Open
pallavithegod wants to merge 1 commit into
pallavithegod wants to merge 1 commit into
Conversation
Shut down per-space compactionExecutor in doClose and doDestroy, and remove its ExecutorServiceMetrics meters. Previously each range leaked a non-daemon thread, blocking JVM exit and growing without bound on split/merge. Fixes apache#290
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each KV space created its own
compactionExecutorbutdoClose/doDestroynever shut it down. Non-daemon threads accumulated on split/merge and blocked JVM exit.Fix
shutdownNowthe executor indoCloseanddoDestroy.kvspace.executormeters registered byExecutorServiceMetrics.monitor, scoped by space tags.Fixes #290
Verification
base-kv-local-engine-rocksdbcompiles: BUILD SUCCESS.