Repository navigation
Fix EMALong reviving stale value after idle period - #319
Open
pallavithegod wants to merge 1 commit into
Open
pallavithegod wants to merge 1 commit into
pallavithegod wants to merge 1 commit into
Conversation
get applies time-based decay without writing it back, but update blended onto the raw undecayed value. Extract decay calculation and use decayed base in update so get and update agree. Fixes apache#301
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get()applies time-based decay without writing it back, butupdate()blended onto the raw undecayed value. After idle,get()reported low congestion while the nextupdate()revived ~90 percent of the stale value.Fix
decay(state, now).update()blends onto the decayed base;get()delegates to the same method. Reads stay side-effect free.updateAfterIdleUsesDecayedBase.Fixes #301
Verification
EMALongTest: 8 tests, 0 failures.