Repository navigation
Fix UTF8Util rejecting valid non-BMP characters, accepting lone surrogates - #318
Open
pallavithegod wants to merge 1 commit into
Open
pallavithegod wants to merge 1 commit into
pallavithegod wants to merge 1 commit into
Conversation
…gates isSurrogatePair returns true for valid pairs, but the code treated it as failure. Validate unpaired surrogates instead, including leading low and trailing high surrogates. Fixes apache#287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Character.isSurrogatePairis true for valid pairs, but the code treated it as failure: emoji and CJK Extension B+ were rejected while lone surrogates were accepted.Fix
UTF8UtilTest.mustNotCharswhich asserted the wrong behavior.Fixes #287
Verification
./mvnw -pl bifromq-util -am test -Dtest=UTF8UtilTest,TopicUtilsTest: 13 tests, 0 failures.