Skip to content

ATLAS-5432:ATLAS-5425: changes to make fail-fast:false - #794

Merged
pinal-shah merged 1 commit into
apache:masterfrom
bhor-sanket:ATLAS-5432-1
Oct 30, 2026
Merged

pinal-shah merged 1 commit into
apache:masterfrom
bhor-sanket:ATLAS-5432-1

Conversation

@bhor-sanket

@bhor-sanket bhor-sanket commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Problem Statement :

  • Existing behavior: The CI matrix strategy in .github/workflows/ci.yml uses the GitHub Actions default fail-fast: true. When the JDK 8 job fails (or vice versa), GitHub Actions immediately cancels the still-running JDK 17 job.
  • Expected behavior: Both JDK 8 and JDK 17 jobs should run to completion independently, regardless of whether the other job fails.
  • Root cause: The strategy block did not explicitly set fail-fast: false, so GitHub Actions applied its default behavior of cancelling sibling matrix jobs on the first failure.
  • Impact: Developers and reviewers lose visibility into the JDK 17 build/test results whenever JDK 8 fails first (and vice versa). This forces contributors to push additional commits or re-run workflows just to obtain the missing results, slowing down the review cycle.

How the patch resolves it :

  • Added fail-fast: false to the strategy block of the docker-build job in .github/workflows/ci.yml.
  • This single-line change ensures that both matrix jobs (JDK 8 and JDK 17) always run to completion, regardless of whether one of them fails.
  • No other workflow behavior, job ordering, or timeout settings are affected.

How was this patch tested?

Setup :

  • GitHub Actions CI pipeline on the ATLAS-5432-1 branch
  • GitHub Actions runner: ubuntu-22.04
  • Matrix: JDK 8, JDK 17
  • Build tool: Maven

Use-cases validation :

  • Use case: One matrix job (e.g., JDK 8) fails while the other (JDK 17) is still running.
    • Expected result: The JDK 17 job continues to completion and reports its own pass/fail status independently.
    • Actual result: as expected
    • Test status: PASSED

Unit testing :

  • No unit tests added or modified — this is a CI workflow configuration change only.
  • Existing unit and integration tests executed by the CI pipeline remain unchanged.

@pinal-shah
pinal-shah merged commit 8b3f674 into apache:master Oct 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants