Conversation
…eader-test for simdjson 5.0 (#51661) ### Rationale for this change See #51638 - `fractured_json` formatting changes with the new simdjson version 5.0 (whitespace, line breaks, key order in tables), cause `parquet-reader-test` to fail on four of its tests `TestJSONWithLocalFile.JSONOutput...` ### What changes are included in this PR? Check `simdjson::SIMDJSON_VERSION_MAJOR`, and for `>= 5` use the new expected formatting (JSON content hasn't changed). Keep existing expected output formatting for simdjson 4.x ### Are these changes tested? Yes, CI runs pass. ### Are there any user-facing changes? No, only test changes. ### Was AI used for this PR? **PR code and description written by:** - [x] Human - [x] AI **Reviewed before submission by:** - [x] Human - [ ] AI - [ ] Not reviewed * GitHub Issue: #51638 Authored-by: Tadeja Kadunc <tadeja.kadunc@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…pkg and force Windows image rebuild to fix builds on wheels (#51676) ### Rationale for this change We have bumped UriParser from a vendored version to be built from external sources. We have to rebuild Windows wheels and we have to apply a fix for older GLIBC see the following upstream commit: - uriparser/uriparser@072a97c ### What changes are included in this PR? Apply to vcpkg the upstream commit to fix older GLIBC. ### Are these changes tested? Yes via archery wheels builds ### Are there any user-facing changes? No ### Was AI used for this PR? In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR. **PR code and description written by:** - [x] Human - [x] AI I've used AI to analyze the errors. Changes have been added and applied by me locally. **Reviewed before submission by:** - [x] Human - [ ] AI - [ ] Not reviewed * GitHub Issue: #51675 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
raulcd
requested review from
HuaHuaY,
assignUser,
jonkeane,
kou,
pitrou and
wgtmac
as code owners
October 2, 2026 07:25
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR, could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
github-actions
Bot
added
Component: Parquet
Component: C++
awaiting committer review
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Default bundled builds lose four existing JSON regression tests, and the PR is explicitly marked as non-mergeable.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates release-branch CI compatibility while explicitly remaining non-mergeable.
Changes:
- Adapts Parquet JSON expectations for simdjson 5.
- Patches uriparser for glibc 2.28.
- Invalidates the Windows wheel image cache.
| File | Description |
|---|---|
cpp/src/parquet/reader_test.cc |
Updates simdjson-dependent JSON expectations. |
ci/vcpkg/ports.patch |
Adds the uriparser compatibility patch. |
.env |
Bumps the Windows wheel image revision. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@github-actions crossbow submit --group packaging |
|
Revision: 1deceed Submitted crossbow builds: ursacomputing/crossbow @ actions-cc342bddce
|
Member
Author
|
@github-actions crossbow submit --group verify-rc-source |
|
Revision: 1deceed Submitted crossbow builds: ursacomputing/crossbow @ actions-e096fcd745
|
…51683) ### Rationale for this change Changes around UriParser, including #51007, caused example-cpp-minimal-build-static-system-dependency to fail to build. ### What changes are included in this PR? This change adds liburiparser-dev to the system dependency image. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. ### Was AI used for this PR? In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR. **PR code and description written by:** - [x] Human - [ ] AI **Reviewed before submission by:** - [x] Human - [ ] AI - [ ] Not reviewed * GitHub Issue: #51682 Authored-by: Hiroyuki Sato <hiroysato@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge this PR.
This PR is being used to test the status of the 26.0.0 release branch on CI and should not be merged.