Repository navigation
docs: fix async memory tool example - #1981
Closed
nightcityblade wants to merge 1 commit into
Closed
nightcityblade wants to merge 1 commit into
nightcityblade wants to merge 1 commit into
Conversation
Author
|
Closing this as a duplicate of #1291. I missed the older linked PR during my duplicate check—sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this solves
The
BetaAsyncAbstractMemoryTooldocstring currently shows the synchronous base class, synchronous handlers, and synchronous client. Following it raises errors instead of demonstrating the async API.Why this change was made
The example now subclasses
BetaAsyncAbstractMemoryTool, defines async handlers, usesAsyncAnthropic, and awaits the tool runner inside anasyncioentry point.User impact
Users can copy the async memory-tool example and follow the correct async control flow.
Evidence
.venv/bin/ruff check src/anthropic/lib/tools/_beta_builtin_memory_tool.py.venv/bin/ruff format --check src/anthropic/lib/tools/_beta_builtin_memory_tool.py.venv/bin/pytest -n 0 tests/lib/tools/memory_tools/test_filesystem.py(69 passed)Fixes #1290