Repository navigation
fix(github-actions): enforce approval SHA freshness and harden post-approval review requests - #4024
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the post-approval changes GitHub Action by extracting its core logic into a separate module, adding comprehensive unit tests, and enhancing its behavior to handle reopened events, ignore comment-only reviews, and re-request reviews from all stale approvers. Additionally, it updates the pull request validation to ensure that at least one team member's review is on the latest commit. The review feedback suggests wrapping individual token revocations in separate try-catch blocks within the finally block to prevent token leaks if one revocation fails, and adding defensive null checks for the review object during validation to avoid potential runtime crashes.
8637afd to
0b46e3a
Compare
…st-approval-changes
…tained in post-approval-changes
0b46e3a to
3f0a7ee
Compare
|
This PR was merged into the repository. The changes were merged into the following branches:
|
2 participants
Enforce commit SHA freshness on pull request approvals in post-approval-changes (including on reopened events), ignore trailing COMMENTED reviews when deduplicating reviewer states, re-request all stale Googler approvers on new commits, and fail closed if the googlers org installation token cannot be obtained.