Repository navigation
fix(ng-dev): scrub GitHub tokens from build worker child process environment - #4023
Merged
josephperrott merged 1 commit intoOct 12, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances security and robustness around GitHub tokens by scrubbing sensitive environment variables (such as GITHUB_TOKEN, TOKEN, GH_TOKEN, and SNAPSHOT_BUILDS_GITHUB_TOKEN) from process.env after configuring the authenticated git client and before invoking build workers. It also updates AuthenticatedGitClient to track the specific token environment variable name dynamically. Feedback on the changes includes a recommendation to remove an unused named import fork in ng-dev/release/build/index.ts.
josephperrott
force-pushed
the
fix/build-worker-token-scrubbing
branch
from
October 9, 2026 18:33
26fd72e to
06a883c
Compare
josephperrott
changed the title
josephperrott
force-pushed
the
fix/build-worker-token-scrubbing
branch
from
October 9, 2026 18:55
06a883c to
3e4ab7a
Compare
alan-agius4
approved these changes
Oct 12, 2026
josephperrott
force-pushed
the
fix/build-worker-token-scrubbing
branch
3 times, most recently
from
October 12, 2026 12:18
83618dc to
02d582c
Compare
…ronment Scrub GITHUB_TOKEN, TOKEN, GH_TOKEN, and SNAPSHOT_BUILDS_GITHUB_TOKEN from the child process environment when spawning the release build worker, and delete GITHUB_TOKEN and TOKEN from process.env after configuring AuthenticatedGitClient while tracking the source environment variable name for push URL hints.
josephperrott
force-pushed
the
fix/build-worker-token-scrubbing
branch
from
October 12, 2026 13:57
02d582c to
359d229
Compare
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrub
GITHUB_TOKEN,TOKEN,GH_TOKEN, andSNAPSHOT_BUILDS_GITHUB_TOKENfrom the child process environment when spawning the release build worker, and deleteGITHUB_TOKENandTOKENfromprocess.envafter configuringAuthenticatedGitClientwhile tracking the source environment variable name for push URL hints.