Repository navigation
Eleven wrapped callbacks and remote-config isSupported hold the app unstable until something that may never happen #3826
Description
Version info
Angular: 22.2
Firebase: 12.19.0
AngularFire: 22.0.0-rc.0, and main
Description
ɵzoneWrap registers an Angular pending task as soon as a wrapped function is passed a callback, and releases it only when that callback first runs or the returned unsubscribe is called.
That is right for onValue, onSnapshotsInSync and onAuthStateChanged, which deliver a first value on attach. Eleven wrapped calls take a callback that a normal page load may never run, in which case ApplicationRef.isStable would stay false for good:
onLogfrom@angular/fire/app: never stable until some Firebase SDK logs, which a quiet app never does. It returnsvoid, so no unsubscribe can release the task either.onTokenChangedfrom@angular/fire/app-check: never stable until a token is obtained. With the setupdocs/app-check.mdshows (noisTokenAutoRefreshEnabled), a first visit that makes no protected request never obtains one.onChildAddedfrom@angular/fire/database: never stable on an empty node. A new listener's initial events are onlychild_added, one per existing child, andvalue.onChildChanged,onChildMoved,onChildRemovedfrom@angular/fire/database: never stable until someone changes, moves or removes a child. None of them fires on attach.off(query, eventType, callback)from@angular/fire/database: never stable. It never calls the callback it is given and returnsvoid.enableLogging(fn)from@angular/fire/database: never stable until the database SDK logs something.fromRefon a child event, andstateChangesandauditTrailwith their default events, from@angular/fire/database: never stable on an empty node. They emit only on child events, so the taskpendingUntilEventregistered is never released.
isSupported from @angular/fire/remote-config is a twelfth case with a different cause:
- Its promise settles when an IndexedDB check answers, so a browser that never answers holds the app for good.
- zone log verbosity #3613 added
isSupported: { blockUntilFirst: false }for it, matching the analytics and messaging copies, but in therxfire/remote-configblock oftools/build.ts, which exports noisSupported. The generator ignored the entry and remote-config shippedtrue. - build: classify the firebase symbols a version raise would newly wrap #3759 deleted the dead entry and left the move for a follow-up.
How to reproduce these conditions
On a fresh Angular 22 app with @angular/fire@next, wrap each real function with ɵzoneWrap at true (the generated line), call it the way a constructor does, inside the Angular zone and an injection context, against the Database and Firestore emulators, and record every ApplicationRef.isStable emission:
onLog,onTokenChanged(provider with no token, no auto refresh),onChildAddedon an empty node,onChildChanged,onChildMovedandonChildRemovedon a node with three children: unstable from 0 ms, still unstable at 3 seconds, callback never ran. Same in a zone.js app and a zoneless one.onChildAddedon a node with three children,onValue,onSnapshotsInSync,onTokenChangedwith auto refresh on: unstable from 0 ms, stable again within 2 to 23 ms when the callback ran.- With
false: no task registered, and inside the callbackinject()still works and, under zone.js,NgZone.isInAngularZone()is still true.
A fresh Angular 22 SSR app that registers an onLog handler inside provideAppInitializer: with onLog imported from @angular/fire/app, ng build fails after about 30 seconds, the route extractor's timeout, with Routes extraction was aborted. TimeoutError: The operation was aborted due to timeout. With the identical file importing from firebase/app, it builds in about 2 seconds. That is the failure #3748 reported for beforeAuthStateChanged.
For isSupported: true holds the app unstable until the IndexedDB check answers, and for the whole window when indexedDB.open is stubbed to never fire. false registers no task. Inside the caller's .then, inject() throws and the zone is the one that attached the .then, at both values.
Expected behavior
A wrapped call whose first callback is not guaranteed by subscribing does not hold the application unstable, as onMessage, onRegistered, onUnregistered and beforeAuthStateChanged already do not. isSupported from @angular/fire/remote-config is wrapped like the analytics and messaging copies.
Actual behavior
All twelve are wrapped with blockUntilFirst true.
Activity