Repository navigation
Conversation
size-limit report 📦
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verifies that the initial exposure snapshot (rescan DOM, then flush
[Amplitude] Viewport Content Updated) runs again on each page navigation, not only on first load.No source change was needed: every page-end path in
handleViewportContentUpdated(andrearmDeferredPageViewfor redirect and in-flight navigation cases) callsinitialExposureSnapshotScheduler.reset(), which re-arms the snapshot. Before this PR, only the "second URL change within 100ms" case was explicitly tested.This adds regression tests that let the initial page-load snapshot complete, navigate, expose an element, and assert that a fresh snapshot flushes it, for:
history.pushStatehistory.replaceStatepopstatenavigate+navigatesuccessI confirmed that removing the
reset()call on page end makes all four tests fail.Checklist