Repository navigation
feat: add event_log_level config to control per-event logging - #80
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
daniel-graham-amplitude
approved these changes
Oct 15, 2026
daniel-graham-amplitude
left a comment
Contributor
There was a problem hiding this comment.
Lgtm, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResponseProcessor.log()always logs every sent or dropped event at INFO level, which can be noisy for high-volume services. This adds aConfigoption so the caller decides how those per-event logs are emitted:EventLogLevelenum (NONE,DEBUG,INFO) inamplitude.constants, exported fromamplitude.Config.event_log_level, defaultEventLogLevel.INFO(keeps current behavior).ResponseProcessor.log()skips logging forNONEand useslogger.debug/logger.infootherwise. Applies to everylog()call (success, invalid, payload-too-large, storage-full, unknown errors).logger.exceptionfor failing user callbacks is unchanged.Checklist
🤖 Generated with Claude Code
Note
Low Risk
Observability-only change with backward-compatible default; no changes to event delivery, callbacks, or retry logic.
Overview
Adds
event_log_levelonConfigso callers can tune how per-event send/drop logs are emitted instead of always using INFO.Introduces
EventLogLevel(NONE,DEBUG,INFO), exported from the package, with defaultINFOso existing behavior is unchanged.ResponseProcessor.log()now skips logging when set toNONE, useslogger.debugforDEBUG, andlogger.infootherwise for all paths that calllog()(success, validation failures, storage full, etc.). User callbacklogger.exceptionbehavior is untouched.Unit tests cover default INFO, DEBUG, and disabled logging on successful sends.
Reviewed by Cursor Bugbot for commit 1221ffa. Bugbot is set up for automated code reviews on this repo. Configure here.