Skip to content

Make journal timestamps timezone-aware - #314

Merged
alexandraBara merged 5 commits into
developmentfrom
amd/bugfix/journal_timezone_aware
Oct 21, 2026
Merged

alexandraBara merged 5 commits into
developmentfrom
amd/bugfix/journal_timezone_aware

Conversation

@amd-etannant

@amd-etannant amd-etannant commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Parse journal timestamps as UTC-aware datetimes so naive ISO strings and epoch microseconds compare correctly.
  • Decode journald MESSAGE byte arrays to UTF-8 text.

Test plan

  • Added unit tests for UTC timestamps and non-UTF-8 message byte arrays
  • pytest test/unit

Comment thread nodescraper/plugins/inband/journal/journaldata.py Outdated

@amd-ansonyim amd-ansonyim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, note that we will start enforcing LF line endings on pre-commit

@alexandraBara
alexandraBara merged commit dc15173 into development Oct 21, 2026
7 checks passed
@alexandraBara
alexandraBara deleted the amd/bugfix/journal_timezone_aware branch October 21, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants