Skip to content

fix(apps): stop sending --queries when publishing data apps - #137

Merged
utay merged 3 commits into
mainfrom
yu/fix-data-apps-without-queries
Oct 12, 2026
Merged

utay merged 3 commits into
mainfrom
yu/fix-data-apps-without-queries

Conversation

@utay

@utay utay commented Oct 12, 2026

Copy link
Copy Markdown
Member

Queries now live in defineDataApp inside index.tsx. Drop --queries from app validate, publish, and update so those commands match the current API.

@utay utay self-assigned this Oct 12, 2026

@francoischalifour francoischalifour left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to regenerate the CLI reference after these modifications

Comment thread COMMANDS.md
Comment thread COMMANDS.md
@albert20260301

Copy link
Copy Markdown
Contributor

The required repository/integration check is failing only because COMMANDS.md was not fully regenerated from the updated command metadata. I opened stacked PR #138 with the three generated description lines; it targets this branch and will unblock the check once merged.

## Summary

- regenerate `COMMANDS.md` from PR #137's updated command metadata
- restore the generated description text required by the
repository-integrity CI check

## Validation

- `git diff --check`
- `bun run generate:commands`
- `bun run generate:check` *(blocked locally because the checkout lacks
the `typescript` dependency required by `openapi-typescript`; CI
installs the locked dependency set and will verify the generated
artifacts)*

This is a stacked PR targeting `yu/fix-data-apps-without-queries`;
merging it restores PR #137's required generated-artifact check.
@utay
utay merged commit 5e6ba5b into main Oct 12, 2026
12 checks passed
@utay
utay deleted the yu/fix-data-apps-without-queries branch October 12, 2026 10:37
utay pushed a commit that referenced this pull request Oct 12, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.10.1](v1.10.0...v1.10.1)
(2026-10-12)


### Bug Fixes

* **apps:** stop sending --queries when publishing data apps
([#137](#137))
([5e6ba5b](5e6ba5b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants