Repository navigation
refactor: use native sign instead dirctl - #148
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Árpád Csepi <csepi.arpad@outlook.com>
arpad-csepi
force-pushed
the
refactor/replace-dirctl-with-cosign
branch
from
October 20, 2026 11:38
d6ea741 to
d7410f9
Compare
Signed-off-by: Árpád Csepi <csepi.arpad@outlook.com>
arpad-csepi
force-pushed
the
refactor/replace-dirctl-with-cosign
branch
from
October 20, 2026 11:43
2e5bcf0 to
28244fd
Compare
Signed-off-by: Árpád Csepi <csepi.arpad@outlook.com>
Signed-off-by: Árpád Csepi <csepi.arpad@outlook.com>
Signed-off-by: Árpád Csepi <csepi.arpad@outlook.com>
arpad-csepi
force-pushed
the
refactor/replace-dirctl-with-cosign
branch
from
October 20, 2026 12:11
4c0c954 to
dea7738
Compare
Signed-off-by: Árpád Csepi <csepi.arpad@outlook.com>
arpad-csepi
changed the title
arpad-csepi
changed the title
Closed
arpad-csepi
marked this pull request as ready for review
October 20, 2026 16:57
adamtagscherer
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are to remove dirctl dependency as a binary and re-implement cosign related functionality directly in the SDK. New tests are added to ensure the sign and verify yields the same result in dirctl and the native implementation.