Repository navigation
fix: catalog.json count was stale - #396
Conversation
There was a problem hiding this comment.
Correction: I applied a DCO sign-off requirement that is not present in this repository's CONTRIBUTING.md or the organization's default contributing guidance. I withdraw that objection; it should not block this PR.
The exact-head catalog correction is technically verified: generated parity confirms 50 integrations, all 50 manifests validate, seven focused tests pass, and diff whitespace is clean. A corrected approval follows.
Reviewed with OpenAI Codex.
carloshvp
left a comment
carloshvp
left a comment
There was a problem hiding this comment.
Approving exact head 1213554a560b77fda51b18ec674b405c93031c03. The single count correction from 49 to 50 matches the generated catalog exactly. All 50 manifests validate, the seven focused catalog/validation tests pass, and the diff whitespace check is clean.
This supersedes my sign-off-only changes request, which I have corrected: the integrations contribution policy does not require the DCO condition I applied. No code change is needed for this count correction.
The metadata regeneration in #398 includes the same existing count correction alongside its tier change; coordinate the resulting generated file after either change lands. Repository checks and maintainer policy remain separate merge requirements.
Reviewed with OpenAI Codex.
PR #351 added the new PIC Standard MCP Guard integration to catalog.json but forgot to bump the count field (stayed at 49 instead of 50). This updates just that one number to match the actual integrations array length. Verified with python scripts/generate_marketplace_catalog.py output and all 5 tests in test_generate_marketplace_catalog.py now pass.