Repository navigation
ate-setup: register ExternalVolumeClasses for the installed CSI drivers - #3780
Open
Vu Le (lekhoavu2909) wants to merge 18 commits into
Open
Vu Le (lekhoavu2909) wants to merge 18 commits into
Vu Le (lekhoavu2909) wants to merge 18 commits into
Conversation
regenerate ateapi.go, and register ExternalVolumeClass in apitool TestBuild_Annotations. Signed-off-by: Vu Le <vulk@google.com>
controlapi.ServiceImpl store pass-throughs Signed-off-by: Vu Le <vulk@google.com>
table truncation and driver_name column test Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
apitool example Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Vu Le (lekhoavu2909)
changed the title
Vu Le (lekhoavu2909)
marked this pull request as ready for review
November 11, 2026 00:15
Signed-off-by: Vu Le <vulk@google.com>
Vu Le (lekhoavu2909)
force-pushed
the
evc-pr6-setup
branch
from
November 11, 2026 01:32
aa971fa to
2448c29
Compare
| // resources for the selected CSI driver when the ExternalVolumes preview gate | ||
| // is enabled and ate-api-server is deployed. Existing classes with the same | ||
| // spec are kept; differing specs return an error. | ||
| func (e *Env) RegisterExternalVolumeClasses(ctx context.Context, driver string) error { |
Collaborator
Author
There was a problem hiding this comment.
The previewGateEnabled and DeploymentExists("ate-api-server") guards let ate-setup setup csi succeed in CI's preview-off lane (pr-workflow.yaml) and when setup csi is run before deploy ate-system.
1 of 2 tasks
41 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ExternalVolumes preview gate is enabled, ate-setup now creates an ExternalVolumeClass for each CSI driver it installs, so templates can use external_volume_class without setting up classes by hand. Stacked on #3776: the NFS class uses mountOptions.
Part of #3754
AI use: AI-assisted, I reviewed and tested it.
No breaking change. Setup only adds classes when the ExternalVolumes gate is on.