Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6d9c742
add global-scoped ExternalVolumeClass message in ateapi.proto,
lekhoavu2909 Nov 6, 2026
5fcea16
add sql migration on store.Interface and atepg.Persistence, unittest,
lekhoavu2909 Nov 6, 2026
ac15cf9
add EVC CRUD, delete precondition, pruning tests, EVC to atepg test
lekhoavu2909 Nov 6, 2026
60152ee
add Substrate Authors headers
lekhoavu2909 Nov 9, 2026
722a190
openFGA model, contextual tuples and authz helpers
lekhoavu2909 Nov 9, 2026
5f005db
ExternalVolumeClass CRUD RPCs, validation, RPC permission registry and
lekhoavu2909 Nov 9, 2026
32dddc1
resource model and authorization docs
lekhoavu2909 Nov 9, 2026
5a58f85
RPCService and ServiceImpl handlers and serviceStore interface
lekhoavu2909 Nov 9, 2026
1594d1f
functionaltest CRUD, precondition, preview-gate and validation tests
lekhoavu2909 Nov 9, 2026
f60f6a6
ExternalVolumeTemplate field, union validation, and validation tests
lekhoavu2909 Nov 10, 2026
09b5583
volume resolver, provisioning wiring, and unit+functional tests
lekhoavu2909 Nov 10, 2026
33d6e7f
ExternalVolumeClass printer and unit tests
lekhoavu2909 Nov 10, 2026
8de3dcc
kubectl-ate get/create/delete commands and unit tests
lekhoavu2909 Nov 10, 2026
5c0456a
CLI reference documentation
lekhoavu2909 Nov 10, 2026
ae98b24
add proto, validation, codegen, apitool example
lekhoavu2909 Nov 10, 2026
bf04614
add controlapi resolver and ExternalVolumeStatus wiring
lekhoavu2909 Nov 10, 2026
375d7e7
add runtime path: ateletpb, workload_spec, atelet, and CSI MountFlags
lekhoavu2909 Nov 10, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,864 changes: 1,157 additions & 707 deletions api/ateapi/v1/ateapi.pb.go

Large diffs are not rendered by default.

142 changes: 140 additions & 2 deletions api/ateapi/v1/ateapi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,28 @@ service Control {
option (method).resource = "Atespace";
}

// Create an ExternalVolumeClass.
rpc CreateExternalVolumeClass(CreateExternalVolumeClassRequest) returns (ExternalVolumeClass) {
option (method).resource = "ExternalVolumeClass";
}

// Get an ExternalVolumeClass by name.
rpc GetExternalVolumeClass(GetExternalVolumeClassRequest) returns (ExternalVolumeClass) {
option (method).resource = "ExternalVolumeClass";
}

// List ExternalVolumeClasses.
rpc ListExternalVolumeClasses(ListExternalVolumeClassesRequest) returns (ListExternalVolumeClassesResponse) {
option (method).resource = "ExternalVolumeClass";
}

// Delete an ExternalVolumeClass. Delete does not check for ActorTemplates
// that still reference the class. Volumes from those templates then fail to
// provision.
rpc DeleteExternalVolumeClass(DeleteExternalVolumeClassRequest) returns (ExternalVolumeClass) {
option (method).resource = "ExternalVolumeClass";
}

rpc CreateActorTemplate(CreateActorTemplateRequest) returns (ActorTemplate) {
option (method).resource = "ActorTemplate";
}
Expand Down Expand Up @@ -533,6 +555,16 @@ message ExternalVolumeStatus {
// +k8s:optional
// +k8s:customValidation # at most 40 KiB in total, ten times the CSI limit for map fields
map<string, string> volume_context = 4;

// mount_options from the volume's class, passed to the CSI driver as
// VolumeCapability.Mount.MountFlags at mount time.
//
// +k8s:optional
// +k8s:maxItems=32
// +k8s:listType=atomic
// +k8s:eachVal=+k8s:minLength=1
// +k8s:eachVal=+k8s:maxLength=256
repeated string mount_options = 5;

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Field 5 collides with #3746 (external_volume_name) and #3102; whichever PR merges second will bump to 6

}

message Actor {
Expand Down Expand Up @@ -1554,11 +1586,66 @@ message ExternalVolumeTemplate {
int64 capacity_bytes = 1;

// storage_class_name names the cluster-scoped Kubernetes StorageClass to
// create the volume from. Required.
// create the volume from. Prefer external_volume_class.
//
// +k8s:required
// Exactly one of storage_class_name and external_volume_class must be set.
//
// +k8s:optional
// +k8s:unionMember
// +k8s:format=k8s-long-name
string storage_class_name = 2;

// external_volume_class names the ExternalVolumeClass to create the volume
// from. atespace must be empty.
//
// +k8s:optional
// +k8s:unionMember
// +k8s:beta(since: "0.0")=+k8s:subfield(atespace)=+k8s:forbidden # TODO: get rid of beta prefix
ObjectRef external_volume_class = 3;
}

// ExternalVolumeClass names the CSI driver that provisions external volumes
// and the parameters for its CreateVolume call. Global-scoped and immutable:
// metadata.atespace must be empty.
message ExternalVolumeClass {
option (resource) = {
scope : SCOPE_GLOBAL
plural : "ExternalVolumeClasses"
};

// Common resource metadata: name, uid, version, timestamps.
//
// +k8s:required
// +k8s:beta(since: "0.0")=+k8s:subfield(atespace)=+k8s:forbidden # TODO: get rid of beta prefix
ResourceMetadata metadata = 1;

// driver_name is the CSI driver that provisions the volumes, e.g.
// "nfs.csi.k8s.io". It is a DNS subdomain, optionally prefixed with
// "substrate.io/".
//
// +k8s:required
// +k8s:maxLength=63
// +k8s:customValidation # optional "substrate.io/" prefix + DNS-1123 subdomain
string driver_name = 2;

// parameters are passed unchanged to the driver's CreateVolume call. The
// driver defines their keys and values, so they are only bounded in size.
//
// +k8s:optional
// +k8s:maxProperties=32
// +k8s:eachKey=+k8s:maxLength=128
// +k8s:eachVal=+k8s:maxLength=256
map<string, string> parameters = 3;

// mount_options are passed to the CSI driver as
// VolumeCapability.Mount.MountFlags at mount time.
//
// +k8s:optional
// +k8s:maxItems=32
// +k8s:listType=atomic
// +k8s:eachVal=+k8s:minLength=1
// +k8s:eachVal=+k8s:maxLength=256
repeated string mount_options = 4;
}

// SystemInfoVolumeSource is a read-only volume of substrate-generated
Expand Down Expand Up @@ -1719,6 +1806,57 @@ message DeleteAtespaceRequest {
DeleteOptions options = 2;
}

// CreateExternalVolumeClassRequest creates an ExternalVolumeClass.
message CreateExternalVolumeClassRequest {
// The class to create. metadata.name is required and metadata.atespace
// must be empty.
//
// +ate:preview=ExternalVolumes
// +k8s:ifDisabled(ExternalVolumes)=+k8s:forbidden
// +k8s:required
ExternalVolumeClass external_volume_class = 1;
}

// GetExternalVolumeClassRequest identifies the ExternalVolumeClass to get.
message GetExternalVolumeClassRequest {
// The class to get. atespace must be empty.
//
// +k8s:required
// +k8s:beta(since: "0.0")=+k8s:subfield(atespace)=+k8s:forbidden # TODO: get rid of beta prefix
ObjectRef external_volume_class = 1;
}

// ListExternalVolumeClassesRequest asks for a page of ExternalVolumeClasses.
message ListExternalVolumeClassesRequest {
// Pagination controls.
//
// +k8s:optional
ListOptions options = 1;
}

// ListExternalVolumeClassesResponse is one page of ExternalVolumeClasses.
message ListExternalVolumeClassesResponse {
// The page of classes. This list may be empty even if there are more results.
repeated ExternalVolumeClass external_volume_classes = 1;

// Pagination token for the next page. Empty if this is the last page.
string next_page_token = 2;
}

// DeleteExternalVolumeClassRequest identifies the ExternalVolumeClass to delete.
message DeleteExternalVolumeClassRequest {
// The class to delete. atespace must be empty.
//
// +k8s:required
// +k8s:beta(since: "0.0")=+k8s:subfield(atespace)=+k8s:forbidden # TODO: get rid of beta prefix
ObjectRef external_volume_class = 1;

// Optional per-delete preconditions.
//
// +k8s:optional
DeleteOptions options = 2;
}

message CreateActorTemplateRequest {
// The actor template version to create. Server-assigned metadata (uid,
// version, timestamps) is ignored, as are the status fields.
Expand Down
164 changes: 164 additions & 0 deletions api/ateapi/v1/ateapi_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading