Repository navigation
benchmarking: add --burst-size to pace ResumePaused cold resumes in waves - #3750
Merged
Max Smythe (maxsmythe) merged 1 commit intoNov 11, 2026
Conversation
haiyanmeng
reviewed
Nov 10, 2026
…waves Signed-off-by: Sairaj Pokale <sairajpokale@google.com>
Sairaj Pokale (sairajp-rewind)
force-pushed
the
benchmarks/resumepaused-burst
branch
from
November 10, 2026 21:18
7ffe051 to
7a1741a
Compare
haiyanmeng
approved these changes
Nov 10, 2026
haiyanmeng
left a comment
haiyanmeng
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Leave it to Max Smythe (@maxsmythe) for approval.
Max Smythe (maxsmythe)
approved these changes
Nov 11, 2026
Max Smythe (maxsmythe)
left a comment
Max Smythe (maxsmythe)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, nit not worth blocking PR on.
| } | ||
|
|
||
| // sleepCtx blocks for d or until ctx is done. | ||
| func sleepCtx(ctx context.Context, d time.Duration) { |
Collaborator
There was a problem hiding this comment.
🤖 nit 🟢 – dwell in agentsession.go is the same helper. Consider moving one copy to boomerutil and using it from both packages, here or in a follow-up.
Collaborator
|
Merging as doc-only change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResumePausedUserspaces cold resumes one by one through arate.Limiterwith burst1. Smooth pacing measures steady-state throughput at a given average rate, but hides the queueing, CPU throttling, and Postgres connection/lock contention that happen when many actors resume at the same time.Add
--burst-size(burst_sizein/boomer-configand the Locust web UI, default0) to release cold resumes in waves of up toburst_sizeusers everyburst_size / target_rpsseconds while keeping the same average rate (target_rps).burst_sizeis0(default),ResumePausedUserkeeps the existing smooth token-bucket pacing.burst_size > 0, up toburst_sizecallers sleep until the same wave boundary on aburst_size / target_rpsgrid; an overflow or late caller advances to the next boundary on the grid, and live updates toburst_sizeortarget_rps(including across--ladder@target_rpssteps) step forward from the last scheduled boundary using the new period.burst_size < 0orburst_size > 0withouttarget_rps > 0in the boomerknobscodec.Supersedes #2399.
AI use: AI-assisted, I reviewed and tested it.