Repository navigation
ateapi: run lifecycle workflows to their end when the caller goes away - #2558
Open
Davanum Srinivas (dims) wants to merge 2 commits into
Open
Davanum Srinivas (dims) wants to merge 2 commits into
Davanum Srinivas (dims) wants to merge 2 commits into
Conversation
Davanum Srinivas (dims)
force-pushed
the
workflow-outlives-caller
branch
4 times, most recently
from
October 18, 2026 21:06
9f120c5 to
9278fa0
Compare
Bowei Du (bowei)
added
area/api-machinery
area/reliability
kind/bug
Davanum Srinivas (dims)
force-pushed
the
workflow-outlives-caller
branch
4 times, most recently
from
October 22, 2026 12:42
92b1a93 to
4e7680e
Compare
Davanum Srinivas (dims)
force-pushed
the
workflow-outlives-caller
branch
9 times, most recently
from
October 30, 2026 11:25
69c152c to
580b58e
Compare
Davanum Srinivas (dims)
force-pushed
the
workflow-outlives-caller
branch
3 times, most recently
from
November 7, 2026 03:28
2a0286c to
10c292a
Compare
A client cancel or timeout cancelled the lease renewal and the atelet call with it: the actor stayed SUSPENDING or RESUMING with its worker assigned, and a retry could start a second checkpoint on a sandbox that had already saved. acquireLease now drops the caller's cancellation and bounds the workflow at the server's own RPC deadline, which the dropped context carried. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
The functional test for a caller deadline during the restore expected the old behavior: the deadline stopped the workflow, left the actor RESUMING, and an immediate retry finished the resume. Now the first resume runs to its end, so that retry raced the finishing workflow for the lease and failed with Aborted whenever it lost. Move the case to its own test: the caller gets DeadlineExceeded, a retry during the restore gets Aborted, and the actor reaches RUNNING on the same worker without either of them. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Davanum Srinivas (dims)
force-pushed
the
workflow-outlives-caller
branch
from
November 9, 2026 19:10
10c292a to
f667c84
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client cancel or timeout cancelled the lease renewal and the atelet call with it: the actor stayed SUSPENDING, PAUSING or RESUMING with its worker assigned, and a retry could start a second checkpoint on a sandbox that had already saved.
acquireLeasenow drops the caller's cancellation and bounds the workflow at the server's own RPC deadline, which the dropped context carried.Verified on a dense kind cluster where pauses outran the client's deadline: none left stranded.
go test ./cmd/ateapi/internal/controlapi/....