Skip to content

fix(csv-parse): keep parsing after skipped max_record_size and rtrim errors #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LuisFigueroaG wants to merge 1 commit into
base: master
Choose a base branch
from
+84 −13
Open

fix(csv-parse): keep parsing after skipped max_record_size and rtrim errors #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions packages/csv-parse/lib/api/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,9 +415,10 @@ const transform = function (original_options = {}) {
if (this.state.commenting === false) {
if (
max_record_size !== 0 &&
this.state.recordHasError === false &&
this.state.record_length + this.state.field.length > max_record_size
) {
return this.__error(
const err = this.__error(
new CsvError(
"CSV_MAX_RECORD_SIZE",
[
Expand All @@ -430,6 +431,7 @@ const transform = function (original_options = {}) {
this.__infoField(),
),
);
if (err !== undefined) return err;
}
}
const lappend =
Expand All @@ -442,18 +444,21 @@ const transform = function (original_options = {}) {
if (lappend === true && rappend === true) {
this.state.field.append(chr);
} else if (rtrim === true && !this.__isCharTrimable(buf, pos)) {
return this.__error(
new CsvError(
"CSV_NON_TRIMABLE_CHAR_AFTER_CLOSING_QUOTE",
[
"Invalid Closing Quote:",
"found non trimable byte after quote",
`at line ${this.info.lines}`,
],
this.options,
this.__infoField(),
),
);
if (this.state.recordHasError === false) {
const err = this.__error(
new CsvError(
"CSV_NON_TRIMABLE_CHAR_AFTER_CLOSING_QUOTE",
[
"Invalid Closing Quote:",
"found non trimable byte after quote",
`at line ${this.info.lines}`,
],
this.options,
this.__infoField(),
),
);
if (err !== undefined) return err;
}
} else {
if (lappend === false) {
pos += this.__isCharTrimable(buf, pos) - 1;
Expand Down
66 changes: 66 additions & 0 deletions packages/csv-parse/test/option.skip_records_with_error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,72 @@ describe("Option `skip_records_with_error`", function () {
parser.end();
});

it('handle "CSV_MAX_RECORD_SIZE"', function (next) {
const errors: CsvError[] = [];
const parser = parse(
{ max_record_size: 5, skip_records_with_error: true },
(err, records) => {
if (err) return next(err);
records.should.eql([
["a", "b"],
["c", "d"],
["e", "f"],
]);
assert_error(errors, [
{
message:
"Max Record Size: record exceed the maximum number of tolerated bytes of 5 at line 2",
code: "CSV_MAX_RECORD_SIZE",
},
]);
errors.length.should.eql(1);
next();
},
);
parser.on("skip", (err) => {
errors.push(err);
});
// Split the oversized field across writes
parser.write("a,b\n12");
parser.write("3456789,0\nc,d\n");
parser.write("e,f\n");
parser.end();
});

it('handle "CSV_NON_TRIMABLE_CHAR_AFTER_CLOSING_QUOTE"', function (next) {
const errors: CsvError[] = [];
const parser = parse(
{ rtrim: true, skip_records_with_error: true },
(err, records) => {
if (err) return next(err);
records.should.eql([
["a", "b"],
["c", "d"],
["e", "f"],
]);
assert_error(errors, [
{
message:
"Invalid Closing Quote: found non trimable byte after quote at line 2",
code: "CSV_NON_TRIMABLE_CHAR_AFTER_CLOSING_QUOTE",
},
]);
errors.length.should.eql(1);
next();
},
);
parser.on("skip", (err) => {
errors.push(err);
});
parser.write(dedent`
a,b
"1" xx,2
c,d
e,f
`);
parser.end();
});

describe("with `bom` option", function () {
it('handle "CSV_RECORD_INCONSISTENT_FIELDS_LENGTH" with bom (fix #411)', function (next) {
let errors = 0;
Expand Down