Repository navigation
Remove circular dependency from pi eyes - #408
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The single-line removal resolves the ordering cycle without changing service commands or framebuffer dependencies.
0 open findings
What changed in this PR
Removes a systemd ordering dependency from the Pi Eyes installer to address the boot failure reported in #407.
Changes:
- Removes
After=multi-user.targetfrom the generated animation service, breaking the circular boot dependency.
| File | Description |
|---|---|
| pi-eyes.py | Removes the animation service’s conflicting startup ordering. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407.