Repository navigation
1.9.0: fix CI drift from ruby_llm 2.1.1 and faraday-net_http 3.5.0 - #587
Merged
Merged
Conversation
ruby_llm 2.1.1 added RubyLLM::ActiveRecord::Record, the base class its models inherit from, plus MCP credential and provider file records, and its railtie requires them first. The eval script mirrors the railtie's list without Rails, so on 2.1.1 model.rb failed with an uninitialized Record and both conversation tests failed on every CI job. The script now requires the 2.1 files, in the railtie's order, when the release has them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CJAKwnkBaCGr5qjCcmc3kh
This was referenced Oct 14, 2026
faraday-net_http 3.5.0 (2026-10-11) is outside every recent Faraday's "faraday-net_http < 3.5", and ruby_llm 1.x depends on faraday-net_http directly, so Bundler fell back to Faraday 2.0.0, which registers no :net_http adapter: 4 failures and 34 errors in the ruby_llm_1 job on every branch. The job's gemfile now floors Faraday at 2.7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CJAKwnkBaCGr5qjCcmc3kh
TonsOfFun
changed the title
TonsOfFun
marked this pull request as ready for review
October 14, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Ruby CI job now fails two
EvalsRubyLLMConversationTesttests, because ruby_llm 2.1.1 was released aftermain's last green run (247e5bb, 2026-10-08):ruby_llm 2.1 added
active_record/record.rb(the base class its models inherit from),mcp_credential.rbandprovider_file.rb, and its railtie requires them beforemodel.test/evals/support/ruby_llm_conversation_script.rbmirrors the railtie's require list without Rails, so it never loadedrecord.Second drift: Faraday 2.0.0 in the ruby_llm 1.x job
faraday-net_http3.5.0 (2026-10-11) is outside every recent Faraday'sfaraday-net_http < 3.5. ruby_llm 1.x depends onfaraday-net_httpdirectly, so Bundler fell back to Faraday 2.0.0, which registers no:net_httpadapter. Result: 4 failures and 34 errors (:net_http is not registered on Faraday::Adapter) in theruby_llm_1job on every branch.gemfiles/ruby_llm_1.gemfilenow floors Faraday at 2.7, which resolves Faraday 2.14.4 with faraday-net_http 3.4.4.Change
Testing (Ruby 3.3.8)
gemfiles/ruby_llm_1.gemfilewith the floor:test/providers/ruby_llm/{input_requests,protocol,response}_test.rbpass (5, 12 and 22 runs), and so does the conversation eval. Without the floor, the lock resolves Faraday 2.0.0 and these raise the adapter error.gemfiles/ruby_llm_2.gemfilewith ruby_llm 2.1.1:test/evals/ruby_llm_conversation_test.rbpasses 2/2, 46 assertions. Without the fix, the same 2 tests fail with the NameError above.gemfiles/rails8.gemfile: 2/2 pass.This blocks green CI for the 1.9.0 PRs (#584, #586, #585), which hit the same failures. Part of the 1.9.0 set.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CJAKwnkBaCGr5qjCcmc3kh