Conversation
The light page carried the auto icon, the state row read auto/auto/dark instead of auto/light/dark, and one hover frame showed the wrong glyph. The script holds the chosen mode in memory now, so that clearing localStorage from outside no longer makes the control a no-op where storage throws. The screenshot harness was doing exactly that between scenarios, so the module kept the previous scenario's mode and the clicks counted from the wrong place. The harness now dispatches the storage event the module already listens for, which is how a real second tab announces the same change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sheet published with v3.0.0 shows the wrong icons: the light page carries the auto glyph, and the state row reads auto / auto / dark instead of auto / light / dark.
Only
img/switch.pngchanges — no code.The cause is in the screenshot harness rather than the theme. #49 made the script hold the chosen mode in memory, so that clearing
localStoragefrom outside can no longer make the control a no-op where storage throws. The harness was clearinglocalStoragebetween scenarios to reset the switch, so the module kept the previous scenario's mode and the clicks counted from the wrong place. It now dispatches thestorageevent the module already listens for — the same way a second tab announces the change.