Release 3.0.0 - #54
Merged
Merged
Conversation
Major, not minor: activeadmin-plugins#49 changed the default look for every project that does not set variables — anthracite header instead of blue, darker links and buttons, dropdown panels on the surface palette. README's Upgrading section lists the one-line override that restores each. Both artefacts checked with the theme switch in them: gem app/assets/javascripts/wigu/theme_toggle.js ships beside the stylesheet npm prepublishOnly + pack puts src/theme_toggle.js beside src/active_admin_theme.scss The npm install snippet in the README moves to ^3.0.0. Also drops the two references to ActiveAdmin 4. The gemspec pins activeadmin >= 3.0, < 4.0, so describing this theme against a version it does not support only invites the question of whether it does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump left over from #49, which merged before this commit landed on the branch.
Why major
#49 changes the default look for every project that does not set variables: anthracite header instead of blue, darker links and buttons, dropdown panels on the surface palette. Nobody upgrading gets the same admin back without reading the diff, so a minor would be wrong. The README's Upgrading section already carries the one-line override that restores each.
Checked, because the switch is the first JavaScript this gem ships
app/assets/javascripts/wigu/theme_toggle.jsbesideapp/assets/stylesheets/wigu/active_admin_theme.scssnpm run prepublishOnly && npm pack→src/theme_toggle.jsbesidesrc/active_admin_theme.scssThe npm install snippet in the README moves to
^3.0.0.Also
Drops the two references to ActiveAdmin 4 — one in the README, one in a comment in the script. The gemspec pins
activeadmin >= 3.0, < 4.0, so describing this theme against a version it does not support only invites the question of whether it does.