Match the npm package version to the gem - #29
Merged
Merged
Conversation
The gem is at 3.0.1, the npm package at 3.0.0. Nothing under app/assets changed between them -- git log v3.0.0..HEAD -- app/assets is empty, and the tarball built from master hashes to a6520be, byte-identical to the published 3.0.0 -- so this publishes the same contents under the gem's number purely to keep the two version lines readable together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
package.jsonfrom 3.0.0 to 3.0.1 so the npm package carries the same number as the gem.This publishes identical contents
Nothing under
app/assetschanged between the gem's 3.0.0 and 3.0.1:and the tarball built from master hashes to
a6520be2249d593ec98c1b3837efc3d4ef6df685— byte-identical to the published 3.0.0. The two commits that made up the gem's 3.0.1 were aspec.fileswhitelist and a CI matrix change, and neither reachessrc/.So this is a version-alignment release, not a content release. Worth doing only because the two version lines are easier to read when they match; there is no functional reason to upgrade.
Note on the stale
v3.0.0branchWhile checking this I hit a trap worth clearing: the repo has a branch
v3.0.0alongside the tagv3.0.0, pointing at different commits (e4561c4vs463f5e3). Git resolves the bare name to the branch, sogit log v3.0.0..HEADreports three asset commits that actually shipped inside 3.0.0. The branch no longer exists on GitHub but lingers as a stale remote-tracking ref in clones that fetched without--prune. Deleting the local/remote leftovers would stop the next person tripping over it.