Repository navigation
Conversation
1 of 6 tasks
Member
|
I am rejecting this one because even though in French and English the word "Description" is the same, it might not be in other future languages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the duplicate English/French
sites.new.labels.descriptionentries and letf.label :descriptionresolve the existing sharedattributes.descriptiontranslation. Both languages continue to display “Description”.Checked the original key’s consumer and Rails attribute resolution, then opened the new-site form in English/French in live Chromium. The label and editable description field passed; no site was created and no JavaScript errors were reported. This is a verified small cleanup, not a general unused-key purge.
Related to #1660. Independent branch based on
dev. The code patches were tested in a combined local snapshot with #1677 (0067e3e) and our #1678–#1684 changes; patches applied cleanly.git diff --checkpassed.