Repository navigation
Reject directory uploads in project inputs #573 - #2262
Open
0Cymantek0 wants to merge 1 commit into
Open
0Cymantek0 wants to merge 1 commit into
0Cymantek0 wants to merge 1 commit into
Conversation
Detect and reject dropped folders using webkitGetAsEntry().isDirectory. Display a docked notification indicating the count of skipped folders. Update docs/inputs.rst to note that directory uploads are unsupported and must be compressed into an archive before uploading. Signed-off-by: Shuvagata Dey <cymantekfnosz@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Dragging and dropping folders into the inputs upload zone causes the upload process to fail or hang, as direct directory uploads are not supported by the backend pipeline. There was no client-side detection or warning to inform the user that folders cannot be uploaded directly.
Changes
dropHandlerviawebkitGetAsEntry().isDirectorywhile preserving valid files.docs/inputs.rstthat directories must be compressed (.zip,.tar.gz) before upload.The PR is merge ready and tested well locally. I'll add another optional PR shortly with a more larger scope UI and UX enhancement. kept this PR separate as this is a targetted fix towards the existing issue.
Checklist