fix: replace deprecated utcfromtimestamp with fromtimestamp - #656
Draft
owenpearson wants to merge 1 commit into
Draft
owenpearson wants to merge 1 commit into
owenpearson wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
datetime.utcfromtimestamp is deprecated in Python 3.12 and scheduled for removal. Subtracting a naive datetime(1970, 1, 1) drops the deprecated call while keeping _ms_since_epoch and _dt_from_ms_epoch on the naive UTC datetimes they already accept and return. fromtimestamp(0, timezone.utc) is not a drop-in substitute here: it makes the epoch timezone-aware, so _ms_since_epoch raises TypeError for the naive start or end a caller may pass to presence.history, and PresenceMessage.timestamp changes from naive to aware. Aligning presence timestamps on aware datetimes is worth doing, but it is an API change rather than a deprecation fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
owenpearson
force-pushed
the
update-utcfromtimestamp
branch
from
September 29, 2026 16:00
7fa4bcf to
6e25964
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datetime.utcfromtimestamp is deprecated in Python 3.12