Repository navigation
feat(logging): added a structured payload logging with masking and truncation - #1234
Closed
katepallewarprathmesh-sketch wants to merge 1 commit into
Conversation
…tion Provide structured DEBUG-level log events for A2A protocol messages including task requests, state changes, artifacts, negotiation payloads, authorization decisions, and notification subscriptions/deliveries. - Add A2APayloadLoggingConfig with system property support (enabled, max-size default 4KB, masking toggle, custom strategy/sensitive-keys) - Add PayloadMaskingStrategy interface with Default (recursive JSON traversal, regex fallback) and NoOp implementations; default masks token/credentials/password/secret/url etc. case-insensitively - Add PayloadTruncator with [truncated] marker - Add TraceCorrelation via OpenTelemetry reflection + MDC for trace_id/ span_id log correlation - Add StructuredPayloadLogger with fluent SLF4J keyValue fields and convenience methods for task/auth/push/negotiation events - Integrate server-side logging in DefaultRequestHandler (requests, results, auth, push subs), AgentEmitter (state/artifact/message), TaskManager (persisted state/artifact), BasePushNotificationSender (delivery) - Integrate client logging in JSONRPCTransport (requests/results, streaming, push, negotiation) and OpenTelemetry decorators - Add defaults to a2a-defaults.properties and documentation - Add unit tests for truncation, masking, config and structured logger Fixes a2aproject#1221 Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provided structured DEBUG-level log events for A2A protocol messages including task requests, state changes, artifacts, negotiation payloads, authorization decisions, and notification subscriptions/deliveries.
Fixes #1221