Repository navigation
Conversation
Collaborator
Author
|
Supersedes #1228 |
kabir
requested changes
Oct 19, 2026
…propagation PushNotificationSender.sendNotification() changed from void to boolean to let decorators observe delivery outcome. Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
kabir
reviewed
Oct 20, 2026
| @Alternative | ||
| @Priority(1) | ||
| A2AHttpClient createPropagatingClient() { | ||
| return new OpenTelemetryA2AHttpClient(A2AHttpClientFactory.createExcluding("cdi"), openTelemetry); |
Collaborator
There was a problem hiding this comment.
- P1 — OTel bypasses applications’ custom CDI HTTP client: createPropagatingClient is an enabled alternative, so it wins CDI resolution over an application’s normal A2AHttpClient bean. It then deliberately excludes the cdi provider and wraps a built-in JDK/Vert.x client instead. This breaks the documented CDI customization path—for example, custom mTLS, proxy, authentication, or timeouts are silently ignored for push delivery whenever the OTel server extra is present. The propagating client needs to wrap the user-selected client rather than replace it (or use an explicit qualifier/configuration to avoid changing default selection).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1217 🦕