Repository navigation
fix: honor --timeout on card resolution and document wait/polling flags - #94
Open
patil-prajwal wants to merge 4 commits into
Open
patil-prajwal wants to merge 4 commits into
patil-prajwal wants to merge 4 commits into
Conversation
3 of 4 tasks
Contributor
|
Tested this and the timeout now exits 5 instead of 3 for Small nit: the new timeout hint suggests |
Author
|
Good catch on both!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves two related gaps in timeout and wait handling:
Card Resolution Timeout & Error Classification:
compatCardResolverpreviously used a fixed package-level&http.Client{Timeout: 30 * time.Second}. This ignored--timeoutsettings greater than 30s (e.g.--timeout 60s) and bypassedcfg.httpTransport. It now uses anhttp.Clientbounded by the context deadline andcfg.httpTransport.clierr.CardResolutionpreviously classified card resolution timeouts asA2ACLI_ERR_CARD_INVALID(exit 4) orA2ACLI_ERR_IO(exit 3). It now checkserrors.Is(err, context.DeadlineExceeded)and correctly reportsA2ACLI_ERR_TIMEOUT(exit 5).Documentation of Waiting & Timeout Flags:
--wait,--poll-interval, and--timeoutto the key flags table inskills/a2a-cli/SKILL.mdandagent-plugin/skills/a2a-cli/SKILL.md.--waittoskills/a2a-cli/SKILL.md,examples/04-messages-and-tasks/README.md, and rootREADME.md.Which area does this relate to?
Checklist
gofmt -w .andgolangci-lint run).go test ./...).Fixes #95