Repository navigation
fix: show snow when no frontend owns the screen - #8
Conversation
Idle video held black except behind the stock OSD, so a setup with no frontend and no OSD (kiosk mode, the idle screensaver's first stage, a quit frontend) lost its background. Main now reports through status[10] that no frontend owns or is about to take the screen, and the core shows snow for that as well as behind the OSD. The bit is clear at reset, so a frontend start stays black, and a Main that never sets it behaves as before.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (8)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughSnow visibility now responds to either synchronized OSD status or the launcher’s ChangesSnow visibility
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~15 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to No actionable issue is established for this change. It is mergeable after normal checks; the intended kiosk behavior still depends on the matching Main_MiSTer change. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)✅ Passed checks (4 passed)Full details: Linked Issues checkExplanation Issue Resolution Include the matching Main_MiSTer producer for
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zaparoo_osd openand went black again when it closed.status[10]is set. Main sets it whenever no frontend owns or is about to take the screen.rtl/zaparoo_snow_enable.svwith its own test bench,tb/snow_enable_tb.sv.tb/run.shpasses on Icarus, and a full compile intheypsilon/quartus-lite-c5:17.0.2.docker0producesmenu.rbfand passestb/check_timing.py. Not tested on hardware.Closes ZaparooProject/zaparoo-frontend#503
Summary by CodeRabbit