Skip to content

Administration: Remove not-allowed cursor from button color mixins - #14040

Closed
SainathPoojary wants to merge 3 commits into
WordPress:trunkfrom
SainathPoojary:fix/66251
Closed

SainathPoojary wants to merge 3 commits into
WordPress:trunkfrom
SainathPoojary:fix/66251

Conversation

@SainathPoojary

Copy link
Copy Markdown
Member

Removes cursor: not-allowed from the primary, secondary, and tertiary button mixins. This lets disabled buttons use the existing default cursor styles for consistency across the admin.

Trac ticket: https://core.trac.wordpress.org/ticket/66251


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sainathpoojary, afercia, dhruvang21.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@afercia afercia added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Oct 7, 2026
@github-actions github-actions Bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Oct 7, 2026
@afercia

afercia commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

I pushed a commit to remove the remaining 3 occurrences of cursor: not-allowed;. They are all very edge cases and introduce unnecessary inconsistency anyways.

1
In the Classic Widgets page, only the 'Custom HTML` widget used it when the button so save is disabled:

01 custom html widget

2
In the Theme / Plugin file editors. It was used on 'Update File' button when disabled:

02 plugin file editor

3
In the Customizer, when reordering menus or widgets, it was used for the 'Add Items' / 'Add Widgets' button. This didn;t work anyways becayse pointer-events: none; already resets the cursor style:

03 customizer reorder

@afercia afercia added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Oct 7, 2026
@github-actions github-actions Bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Oct 7, 2026
wporg-sync pushed a commit that referenced this pull request Oct 7, 2026
A few buttons had the `cursor: not-allowed;` style applied, which has now been removed. This styling is unnecessary and only introduces inconsistency with other disabled buttons styling.

For the removed styles in `colors/_mixins.scss` it is also worth noting that a style related to interaction should not live in a file that contains mixins dedicated to colors.

- Removes the `cursor: not-allowed` style from buttons mixins in `colors/_mixins.scss`.
- Removes the remaining 3 occurrences for the classic 'Custom HTML' widget, the Theme / Plugin file editors and in the Customizer when reordering menus or widgets.

Developed in #14040

Props sainathpoojary, dhruvang21, afercia.
Fixes #66251.


git-svn-id: https://develop.svn.wordpress.org/trunk@64229 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 64229
GitHub commit: 36e7c85

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Oct 7, 2026
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Oct 7, 2026
A few buttons had the `cursor: not-allowed;` style applied, which has now been removed. This styling is unnecessary and only introduces inconsistency with other disabled buttons styling.

For the removed styles in `colors/_mixins.scss` it is also worth noting that a style related to interaction should not live in a file that contains mixins dedicated to colors.

- Removes the `cursor: not-allowed` style from buttons mixins in `colors/_mixins.scss`.
- Removes the remaining 3 occurrences for the classic 'Custom HTML' widget, the Theme / Plugin file editors and in the Customizer when reordering menus or widgets.

Developed in WordPress/wordpress-develop#14040

Props sainathpoojary, dhruvang21, afercia.
Fixes #66251.

Built from https://develop.svn.wordpress.org/trunk@64229


git-svn-id: http://core.svn.wordpress.org/trunk@63380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants