Repository navigation
Administration: Remove not-allowed cursor from button color mixins - #14040
SainathPoojary wants to merge 3 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
A few buttons had the `cursor: not-allowed;` style applied, which has now been removed. This styling is unnecessary and only introduces inconsistency with other disabled buttons styling. For the removed styles in `colors/_mixins.scss` it is also worth noting that a style related to interaction should not live in a file that contains mixins dedicated to colors. - Removes the `cursor: not-allowed` style from buttons mixins in `colors/_mixins.scss`. - Removes the remaining 3 occurrences for the classic 'Custom HTML' widget, the Theme / Plugin file editors and in the Customizer when reordering menus or widgets. Developed in #14040 Props sainathpoojary, dhruvang21, afercia. Fixes #66251. git-svn-id: https://develop.svn.wordpress.org/trunk@64229 602fd350-edb4-49c9-b593-d223f7449a82
A few buttons had the `cursor: not-allowed;` style applied, which has now been removed. This styling is unnecessary and only introduces inconsistency with other disabled buttons styling. For the removed styles in `colors/_mixins.scss` it is also worth noting that a style related to interaction should not live in a file that contains mixins dedicated to colors. - Removes the `cursor: not-allowed` style from buttons mixins in `colors/_mixins.scss`. - Removes the remaining 3 occurrences for the classic 'Custom HTML' widget, the Theme / Plugin file editors and in the Customizer when reordering menus or widgets. Developed in WordPress/wordpress-develop#14040 Props sainathpoojary, dhruvang21, afercia. Fixes #66251. Built from https://develop.svn.wordpress.org/trunk@64229 git-svn-id: http://core.svn.wordpress.org/trunk@63380 1a063a9b-81f0-0310-95a4-ce76da25c4cd



Removes
cursor: not-allowedfrom the primary, secondary, and tertiary button mixins. This lets disabled buttons use the existing default cursor styles for consistency across the admin.Trac ticket: https://core.trac.wordpress.org/ticket/66251
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.