Proof of concept: Move GB into WordPress 5.3 - #13803
Draft
aaronjorbin wants to merge 6 commits into
Draft
aaronjorbin wants to merge 6 commits into
aaronjorbin wants to merge 6 commits into
Conversation
node-sass 4.12.0 has no prebuilt binary for Node 14, which the 5.3 branch of wordpress-develop requires. 4.14.1 bundles the same libsass (3.5.5), so the compiled package stylesheets are byte-identical to the published ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds a `build:gutenberg` Grunt task, run at the start of `build:js`, which compiles the packages in `gb-src/packages` (build, build-module and build-style) using Gutenberg's own build script and locked toolchain. The toolchain is installed into `gb-src/node_modules` by a new root `postinstall` script. Install scripts are skipped there except for node-sass, which needs its native binding. The webpack packages config no longer resolves symlinks so that once the `@wordpress/*` dependencies are linked from gb-src, module paths (and so the hashed module IDs) stay the same as when installed from npm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Switches every `@wordpress/*` dependency, including the build tooling packages and those pulled in transitively, from npm registry versions to `file:gb-src/packages/*` references. The lock file was rewritten to turn only the `@wordpress/*` entries into links, so every third-party dependency keeps its previously locked version. All versions in gb-src match what was locked before, and the production build output is byte-identical to the npm-based build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ries. The lock still carried nested `@wordpress/element` entries under `@wordpress/compose`, `@wordpress/data`, `@wordpress/plugins` and `@wordpress/babel-preset-default`, left over from the registry-based tree. Now that they are all links to the same gb-src package they are redundant, and npm 6 failed `npm install` on an existing tree while trying to move them into `gb-src/packages/element/node_modules` (ENOENT on rename). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The package build script only counted completed files once the glob stream had ended. Files processed by workers before the stream emitted `end` were never counted, so the completed count could never reach the total, the worker farm was never ended, and the process hung indefinitely. This surfaced as the Windows "Core running from src" job timing out. Always count completed files, and check whether the worker farm can be ended both when a file completes and when the stream ends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept for testing purposes.