Repository navigation
fix(deps): bump tokio to 1.53.3 for RUSTSEC-2026-0386 - #241
Open
Nic-dorman wants to merge 1 commit into
Open
Nic-dorman wants to merge 1 commit into
Nic-dorman wants to merge 1 commit into
Conversation
RUSTSEC-2026-0386: tokio's AsyncFd is unsound. Patched in >=1.51.6,<1.52.0 and >=1.53.3; main was locked at 1.52.3, which sits in the unpatched gap. Lockfile-only change. Cargo.lock is the only lockfile in the repo. Only the tokio version and checksum change (1.52.3 -> 1.53.3); its dependency list is identical, and tokio-macros stays at 2.7.0. `cargo update -p tokio --precise 1.53.3` with cargo 1.97 also rewrites unrelated windows-sys and socket2 edges (windows-sys 0.61.2 -> 0.48/0.52/0.59, socket2 0.6.4 -> 0.5.10), so the version and checksum were edited by hand instead, using the checksum from cargo's own resolution. Verified: cargo metadata --locked, cargo check --locked --all-targets. osv-scanner no longer reports RUSTSEC-2026-0386. Closes V2-1735 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Nic-dorman
force-pushed
the
nic/v2-1735-tokio-rustsec-2026-0386
branch
from
October 23, 2026 19:54
78dbd57 to
a9d9099
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear issue
Closes V2-1735
Part of V2-1733, which tracks the same move across every affected WithAutonomi lockfile.
Risk tier
This tier is proposed rather than asserted, and matches the earlier lockfile advisory moves (V2-1659). The change is lockfile only: tokio moves from 1.52.3 to 1.53.3, and only its version and checksum change. RUSTSEC-2026-0386 is informational ("unsound"). The safe
AsyncFdconstructors violate I/O safety, so closing a duplicated fd can lead to a use-after-free. It is Unix-only. The patched versions are 1.51.6 and 1.53.3 or later. No Autonomi protocol message changes.Compatibility
Semver impact
Test evidence
cargo update --preciseon cargo 1.97 also rewrote unrelated windows-sys edges, so the tokio version and checksum were edited by hand. The checksum is the one cargo itself resolved.cargo metadata --locked: passcargo check --locked --all-targets: passcargo audit: RUSTSEC-2026-0386 is present before the change and gone after. No new advisories.Prod compat smoke (2026-10-23) at the rebased head
a9d90999. Run on Linux (dev2, stable 1.99.1) as a--lockedrelease build ofant-cli.cargo tree -i tokioshowstokio v1.53.3, and the build log compiles only 1.53.3. Every step uses isolatedXDG_DATA_HOME/XDG_CONFIG_HOME.node daemon start, thenstatusover HTTP (running, same PID), thenstop. All exit 0.3cba93c8…(5,277,908 B, 4 chunks) in 17.0 s anded120ab3…(16,666,151 B, 8 chunks) in 23.5 s. Both byte counts match.ant wallet balancefor a freshly generated key returns0.payment error: Insufficient tokens to pay for quotes. Have: 0 atto, need: … atto. That is the same wording asmain.New dependency
none
ADR
n/a
Mitigation / rollback
Revert the single Cargo.lock commit. tokio goes back to 1.52.3.
🤖 Generated with Claude Code